Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two ways in which the default for mpi_memory_alloc_kinds can be interpreted #773

Closed
th-hlrs opened this issue Sep 14, 2023 · 5 comments
Closed

Two ways in which the default for mpi_memory_alloc_kinds can be interpreted #773

th-hlrs opened this issue Sep 14, 2023 · 5 comments
Assignees
@jdinan
Labels
chap-dynamic Process Initialization, Creation, and Management Chapter Committee had reading Completed the formal proposal reading mpi-5.0 For inclusion in the MPI 5.0 standard passed final vote Passed the final formal vote

Comments

@th-hlrs
Copy link

th-hlrs commented Sep 14, 2023

Problem

The new mpi_memory_alloc_kinds can be used to request and to query support for different. If it is used to query what the default is, current wording ('string, default: "mpi,system"') can be read as

  1. a conforming library has to exactly set to/return the value "mpi,system" if nothing else has been requested (e.g. by an start-up mechanism). Thus, no library could by default enable support for GPUs, even if it would make sense;
  2. a conforming library sets the info key/returns the value as if "mpi,system" had been specified by an start-up mechanism. Then also additional memory kinds could be added.

Proposal

It might not make sense to restrict libraries to only offer (default) support for "mpi,system". Then 2. would be better.

Changes to the Text

Add in section 11.4.3 in the definition of mpi_memory_alloc_kinds text similar to:
The default is treated as if the user had requested it.

References and Pull Requests
@wesbland wesbland added the mpi-4.1 For inclusion in the MPI 4.1 standard label Sep 15, 2023
@github-project-automation github-project-automation bot moved this to To Do in MPI 4.1 Sep 15, 2023
@wesbland wesbland added the chap-dynamic Process Initialization, Creation, and Management Chapter Committee label Sep 15, 2023
@hppritcha hppritcha assigned jdinan and unassigned hppritcha Sep 15, 2023
@hppritcha
Copy link

although this is in the process creation chapter, i've not been very involved in the memory kind allocation portion. reassigning to @jdinan

@th-hlrs th-hlrs added mpi-5.0 For inclusion in the MPI 5.0 standard and removed mpi-4.1 For inclusion in the MPI 4.1 standard labels Sep 15, 2023
@github-project-automation github-project-automation bot moved this to To Do in MPI 5.0 Sep 15, 2023
@th-hlrs th-hlrs removed this from MPI 4.1 Sep 15, 2023
@jdinan
Copy link

jdinan commented Nov 17, 2024

It was intended that libraries can include implementation-defined kinds in addition to the default. This is specified further down in the section, but I do agree it needs to be clarified here. Here's one way to clarify this:

"mpi_memory_alloc_kinds" (string, default: "mpi,system"): A comma separated list of memory allocation kinds. ++The default must contain the kinds specified and may contain additional implementation-defined kinds.++

@wesbland wesbland added scheduled reading Reading is scheduled for the next meeting scheduled errata vote Errata vote is scheduled for the next meeting labels Dec 17, 2024
@wesbland wesbland moved this from To Do to In Progress in MPI 5.0 Jan 6, 2025
@wesbland wesbland added the scheduled no-no vote No-No vote is scheduled for the next meeting label Jan 6, 2025
@wesbland
Copy link
Member

wesbland commented Jan 6, 2025

No-no commits: https://github.com/mpi-forum/mpi-standard/pull/986/commits/67b9ea749a50e10bec3e34e261f61e9a21b4e236

@wesbland
Copy link
Member

wesbland commented Jan 9, 2025

This passed a no-no vote.

Yes No Abstain
30 0 0

@wesbland wesbland added had reading Completed the formal proposal reading and removed scheduled no-no vote No-No vote is scheduled for the next meeting scheduled errata vote Errata vote is scheduled for the next meeting scheduled reading Reading is scheduled for the next meeting labels Jan 9, 2025
@wesbland
Copy link
Member

wesbland commented Jan 9, 2025

This passed a errata vote.

Yes No Abstain
30 0 0

@wesbland wesbland added the passed final vote Passed the final formal vote label Jan 9, 2025
@wesbland wesbland moved this from In Progress to Passed 2nd Vote in MPI 5.0 Jan 9, 2025
@wgropp wgropp closed this as completed Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Passed 2nd Vote to Done in MPI 5.0 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdinan jdinan

Labels
chap-dynamic Process Initialization, Creation, and Management Chapter Committee had reading Completed the formal proposal reading mpi-5.0 For inclusion in the MPI 5.0 standard passed final vote Passed the final formal vote
Projects
MPI 5.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wesbland @jdinan @hppritcha @th-hlrs