Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaksa: pack/unpack symbols need hidden visibility #7306

Open
raffenet opened this issue Feb 19, 2025 · 1 comment
Open

yaksa: pack/unpack symbols need hidden visibility #7306

raffenet opened this issue Feb 19, 2025 · 1 comment

Comments

@raffenet
Copy link
Contributor

From MPICH discuss:

Hi,

I’m maintaining MPICH in Debian, and enabling HIP and other dependencies.
In Debian we supply an ELF symbols file, tracking to make sure there are no unexpected ABI changes.

With 4.3.0 there are changes and a lot of new yaksa-related symbols, eg
_Z33yaksuri_hipi_kernel_pack_LOR_boolPKvPvmPK17yaksuri_hipi_md_s@Base 4.3
_Z34yaksuri_hipi_kernel_pack_LAND_boolPKvPvmPK17yaksuri_hipi_md_s@Base 4.3
…
hipFree@Base 4.3
yaksuri_hipi_pack_blkhindx_blkhindx_bool@Base 4.3
yaksuri_hipi_pack_blkhindx_blkhindx_char@Base 4.3
…

Approx 8000 new symbols added to the public interface !

Is this expected ? are these part of the public interface or unexpected leakage? Can they be made private safely?

Thanks
Alastair McKinstry
@raffenet
Copy link
Contributor Author

The issue is the visibility flags are lost when compiling the HIP backend files. hipcc supports -fvisibility=hidden so it should be trivial to add.

mpich/src/mpi/datatype/typerep/yaksa/src/backend/hip/Makefile.mk

Lines 17 to 24 in f0fe4ee

.hip.lo:
@if $(AM_V_P) ; then \
$(top_srcdir)/src/backend/hip/hiplt.sh --verbose $@ \
$(HIPCC) $(AM_CPPFLAGS) -g $(HIP_GENCODE) -c $< ; \
else \
echo " HIPCC $@" ; \
$(top_srcdir)/src/backend/hip/hiplt.sh $@ $(HIPCC) $(AM_CPPFLAGS) -g $(HIP_GENCODE) -c $< ; \
fi

nvcc does not support -fvisibility=hidden. Need to check on ZE backend still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raffenet